Re: [PATCH 1/10] Teach git-completion.bash how to complete git-merge.

From: Shawn Pearce <spearce@spearce.org>
Date: Nov 27, 2006, 20:12 UTC
Message-ID: <20061127201236.GA7331@spearce.org>
In-Reply-To: <7vlklwhffb.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

Show 15 quoted lines

> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > +__git_merge_strategies ()
> > +{
> > +	sed -n "/^all_strategies='/{
> > +		s/^all_strategies='//
> > +		s/'//
> > +		p
> > +		q
> > +		}" "$(git --exec-path)/git-merge"
> > +}
> > +
> 
> Shouldn't we load and compute this once and keep the result in a
> variable (say $__git_merge_strategies)?

Sure.  See my latest 4 patch series.  :-)