Re: [PATCH] Make logAllRefUpdates true by default

From: Shawn Pearce <spearce@spearce.org>
Date: Nov 27, 2006, 05:01 UTC
Message-ID: <20061127050059.GA18970@spearce.org>
In-Reply-To: <7vhcwmt19w.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

Show 8 quoted lines

> I do not think I can take this patch in its current form.
> 
> Although I think majority of users would find it convenient to
> have ref-log enabled by default on repositories to be developed
> in, it does not make sense to enable ref-log by default for bare
> repositories that is used as a distribution point.  So at least
> this needs an option to disable it (if you make it the default),
> or enable it.

What about just suggesting that the individual user run:

	git repo-config --global core.logAllRefUpdates true

This has the effect of enabling reflog by default for any repository that the user creates or clones, unless its explicitly disabled in that repository.

I've done this in any account that I use to access working directory repositories and it works well. But I also just realized that I have it enabled in one account which also pushes to some bare repositories through local filesystem URLs and thus those bare repositories are also getting reflogged. But given that they are used as backups of my working directory repositories (different drive) and are never pruned, I actually consider that to be a feature. :-)

Your idea of guessing the intent of the repository and setting up the configuration based on that intent is a good one, but unfortunately I have no suggestions for how to solve the (1)..(3) cases you raised. But setting core.logAllRefUpdates in the global configuration of an interactive account appears to be a reasonable workaround.