git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: filemode=false somewhat broken

From
Shawn Pearce <spearce@spearce.org>
Date
Nov 25, 2006, 06:10 UTC
Message-ID
<20061125061034.GA4528@spearce.org>
In-Reply-To
<7vodqzp0mh.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
Show 8 quoted lines
> Juergen Ruehle <j.ruehle@bmiag.de> writes:
> 
> > Commit fd28b34afd9bbd58297a25edced3f504c9a5487a tried to ignore the
> > executable bit if filemode=false, but instead forced all files to be
> > regular with 644 permission bits nuking symlink support.
> 
> Thanks for noticing.  Yes, that change is _seriously_ broken.  I
> should really raise the bar for patch acceptance.
Whoops.

I don't work with symlinks so I never noticed the breakage myself. Clearly the test cases that I created in fd28b3 should also have included symlinks, but they did not... and we see this breakage occur.

Previous: Junio C Hamano
Message 3 of 3 in “filemode=false somewhat broken”
  1. Juergen RuehleNov 22, 2006
  2. Junio C HamanoNov 22, 2006
  3. Shawn PearceNov 25, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.