git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/4] Bomb out when --ack and --sign are both passed to "refresh".

From
Yann Dirson <ydirson@altern.org>
Date
Nov 23, 2006, 23:17 UTC
Message-ID
<20061123231708.9769.53781.stgit@gandelf.nowhere.earth>
In-Reply-To
<20061123230721.9769.38403.stgit@gandelf.nowhere.earth>
Old behaviour was silently ignoring --ack, which could be confusing.
Signed-off-by: Yann Dirson <ydirson@altern.org>
---
 stgit/commands/refresh.py |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/stgit/commands/refresh.py b/stgit/commands/refresh.py
index ea0fe6f..aa5ff78 100644
--- a/stgit/commands/refresh.py
+++ b/stgit/commands/refresh.py
@@ -107,6 +107,8 @@ def func(parser, options, args):
 
     if options.sign:
         sign_str = 'Signed-off-by'
+        if options.ack:
+            raise CmdException, '--ack and --sign were both specified'
     elif options.ack:
         sign_str = 'Acked-by'
Previous: Yann DirsonNext: Catalin Marinas
Message 5 of 6 in “Series short description”
  1. 0/4 Series short descriptionYann Dirson, Nov 23, 2006
  2. 1/4 Make Series::patch_applied public.Yann Dirson, Nov 23, 2006
  3. 2/4 Allows to refresh a non-top applied patch.Yann Dirson, Nov 23, 2006
  4. 3/4 Optimize stg goto in the pop case.Yann Dirson, Nov 23, 2006
  5. 4/4 Bomb out when --ack and --sign are both passed to "refresh".Yann Dirson, Nov 23, 2006
  6. Catalin MarinasNov 24, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.