git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] git-fetch: allow glob pattern in refspec

From
APAndy Parkins <andyparkins@gmail.com>
Date
Nov 23, 2006, 08:55 UTC
Message-ID
<200611230855.04124.andyparkins@gmail.com>
In-Reply-To
<7vzmaik4mi.fsf@assigned-by-dhcp.cox.net>
On Thursday 2006 November 23 07:24, Junio C Hamano wrote:
>  * Andy, I think this does the same thing as you wanted to do,
>    but is cleaner implementation-wise and also at the concept

It certainly is. Looking at your implementation I see that I was worrying unnecessarily about passing extra globals/parameters to git-parse-remote. Your version is much better than mine; and I see that noone else calls get_remote_refs_for_fetch anyway.

Show 5 quoted lines
>    level, to pretend as if the user listed the expanded form in
>    the configuration.  I deliberately decided not to apply the
>    wildcard expansion on refspecs that came from command line,
>    but if we wanted to we can move the expand_refs_wildcard call
>    a few lines down to make it also apply to them.

That's probably the most sensible method. Using globs on the command line could get people into trouble if they accidentally hit a shell expansion.

Andy
-- 
Dr Andy Parkins, M Eng (hons), MIEE
Previous: Junio C HamanoNext: Michael Loeffler
Message 2 of 3 in “git-fetch: allow glob pattern in refspec”
  1. 3/3 git-fetch: allow glob pattern in refspecJunio C Hamano, Nov 23, 2006
  2. Andy ParkinsNov 23, 2006
  3. Michael LoefflerNov 27, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.