Re: Adding glob support to remotes
- From
- Andy Parkins <andyparkins@gmail.com>
- Date
- Nov 23, 2006, 08:44 UTC
- Message-ID
- <200611230844.29061.andyparkins@gmail.com>
- In-Reply-To
- <7v3b8bryt6.fsf@assigned-by-dhcp.cox.net>
On Wednesday 2006 November 22 20:50, Junio C Hamano wrote:
> I do not understand and that is why I do not understand why you > would need to touch check-ref-format.
The problem is that I didn't want to call git-ls-remote in git-parse-remote, as git-parse-remote doesn't know about $uploadpack or what the actual remote in use is. It seemed fairly intrusive to completely alter the functions in git-parse-remote; which is obviously a set of library functions.
Instead I did the expansion in git-fetch.sh. Unfortunately that meant disabling the check-ref-format call in canon_refs_list_for_fetch.
> point at" is to ask ls-remote, and if you do one ls-remote > upfront then all you need to do here is a single grep.
I understand now. I'll look again at this tonight and send a further patch.
Andy
-- Dr Andy Parkins, M Eng (hons), MIEE