Re: [PATCH] gitweb: make HTML links out of http/https URLs in changelogs

From: Petr Baudis <pasky@suse.cz>
Date: Nov 22, 2006, 20:56 UTC
Message-ID: <20061122205652.GL7201@pasky.or.cz>
In-Reply-To: <45641195.2000804@openvz.org>

On Wed, Nov 22, 2006 at 10:00:05AM CET, Kir Kolyshkin wrote:

Show 12 quoted lines

> Petr Baudis wrote:
> >On Tue, Nov 21, 2006 at 11:02:36PM CET, Kir Kolyshkin wrote:
> >  
> >>Slightly tested on http://git.openvz.org/. Applicable to git-1.4.4.
> >>    
> >
> >...but in git's gitweb view it will make this <a
> >href="http://git.openvz.org/.">http://git.openvz.org/.</a>. :-)
> Not a problem actually since "." means "current directory", so it will 
> work fine (and I have checked that) :)
> Sure there is a room for improvement for this regex -- and I am 
> collecting those.

But "http://git.openvz.org/index.html." might not work so fine, nor "http://git.openvz.org/,"...

Bad URLs matchers which don't snip unlikely (!= invalid!) characters from the end of the URL are my pet peeve. ;-)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
The meaning of Stonehenge in Traflamadorian, when viewed from above, is:
"Replacement part being rushed with all possible speed."