git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: protect blob and diff output lines from controls.

From
Jakub Narebski <jnareb@gmail.com>
Date
Nov 9, 2006, 09:34 UTC
Message-ID
<200611091034.42190.jnareb@gmail.com>
In-Reply-To
<7vwt65pgqs.fsf@assigned-by-dhcp.cox.net>
Dnia czwartek 9. listopada 2006 02:10, Junio C Hamano napisał:
> Jakub Narebski <jnareb@gmail.com> writes:
Show 6 quoted lines
>> Well, the pathname has the limit that it must be in single line
>> after quoting. The "blob" output is multipage.
> 
> I honestly have _no_ idea what distincition you are seeing
> here.  Both blob and diff output are processed one line at a
> time and its result would be on a single line too.

I was thinking about _conceptual_ difference, not technical. (Perhaps I should make it more clear.)

Pathname is item (or part of item in the case of page_path) which is contained (and must be contained) in single line. It is also expected (although if we follow this expectation is up to us) that the pathname would quote special characters similarly to how shell/operating system quotes pathnames (e.g. in ls output).

"Blob" output on the other hand ("blob" view and patch part of "blobdiff" and "commitdiff" views) is [a part of] larger, multiline whole. One could also expect that special characters would be quoted like editor quotes special characters. (Of course question is: which editor?)

This of course is complicate by single line output like subject or authorship, or signoff, which is not pathname.

All this discussion shows that gitweb quoting is more complicated that I thought.

-- 
Jakub Narebski
Previous: Junio C HamanoNext: Jakub Narebski
Message 6 of 12 in “gitweb: protect blob and diff output lines from controls.”
  1. gitweb: protect blob and diff output lines from controls.Junio C Hamano, Nov 8, 2006
  2. Jakub NarebskiNov 9, 2006
  3. Junio C HamanoNov 9, 2006
  4. Jakub NarebskiNov 9, 2006
  5. Junio C HamanoNov 9, 2006
  6. Jakub NarebskiNov 9, 2006
  7. Jakub NarebskiNov 9, 2006
  8. Junio C HamanoNov 9, 2006
  9. Jakub NarebskiNov 9, 2006
  10. Junio C HamanoNov 9, 2006
  11. Jakub NarebskiNov 9, 2006
  12. Luben TuikovNov 10, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.