git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Allow pack header preprocessing before unpack-objects/index-pack.

From
Shawn Pearce <spearce@spearce.org>
Date
Oct 31, 2006, 20:08 UTC
Message-ID
<20061031200841.GC23671@spearce.org>
In-Reply-To
<Pine.LNX.4.64.0610311400180.11384@xanadu.home>
Nicolas Pitre <nico@cam.org> wrote:
Show 17 quoted lines
> On Tue, 31 Oct 2006, Shawn Pearce wrote:
> 
> > However if the caller consumes the pack header from the input stream
> > then its no longer available for unpack-objects or index-pack --stdin,
> > both of which need the version and object count to process the stream.
> > 
> > This change introduces --pack_header=ver,cnt as a command line option
> > that the caller can supply to indicate it has already consumed the
> > pack header and what version and object count were found in that
> > header.  As this option is only meant for low level applications
> > such as receive-pack we are not documenting it at this time.
> 
> This breaks index-pack, and unpack-objects with OBJ_OFS_DELTA, if 
> --pack-header is used.  The header is not accounted in the pack's offset 
> and therefore every object's offset is wrong.
> 
> What about this patch instead?  This makes things much simpler IMHO.

Agreed. The idea you are using here came to me in my sleep last night; I didn't have time to look at it until now however. You just beat me to posting it. :-)

Previous: Nicolas PitreNext: Junio C Hamano
Message 3 of 4 in “Allow pack header preprocessing before unpack-objects/index-pack.”
  1. 1/2 Allow pack header preprocessing before unpack-objects/index-pack.Shawn Pearce, Oct 31, 2006
  2. Nicolas PitreOct 31, 2006
  3. Shawn PearceOct 31, 2006
  4. Junio C HamanoOct 31, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.