Re: [PATCH/RFC] gitweb: New improved patchset view

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 29, 2006, 12:48 UTC
Message-ID: <200610291348.41389.jnareb@gmail.com>
In-Reply-To: <200610291324.42566.jnareb@gmail.com>

Jakub Narebski wrote:

Show 15 quoted lines

> Junio C Hamano wrote:
>> Jakub Narebski <jnareb@gmail.com> writes:
>>>
>>> * there is added "extended diff header", with <path> and <hash>
>>>   hyperlinked (and <hash> shortened to 7 characters), and <mode>
>>>   explained: '<mode>' is extnded to '<mode>/<symbolic mode> (<file type>)'.
>> 
>> It somehow feels that deviating from what "git diff" gives makes
>> it very distracting; I would feel better if "/-rw-r--r-- (file)"
>> were not there.
> 
> Well, the old version had "(<file type>)" in gitweb diff header.
> Not all git/gitweb users are familiar with POSIX numeric modes;
> perhaps changing the style (color for example) of added stuff
> to mark it as added would be enough?

Or we could use the following code:

  <abbr title="100755/-rwxr-xr-x (file)">100755</abbr>

which gives explanation on mouse-over.

-- 
Jakub Narebski