Re: [PATCH (resend)] gitweb: Use --no-commit-id in git_commit and git_commitdiff
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Oct 26, 2006, 09:37 UTC
- Message-ID
- <200610261137.12211.jnareb@gmail.com>
- In-Reply-To
- <7vejsvpi4d.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
Show 19 quoted lines
> Jakub Narebski <jnareb@gmail.com> writes: > > > Use --no-commit-id option to git-diff-tree command in git_commit and > > git_commitdiff to filter out commit ID output that git-diff-tree adds > > when called with only one <tree-ish> (not only for --stdin). Remove > > filtering commit IDs from git-diff-tree output. > > > > This option is in git since at least v1.0.0, so make use of it. > > *BLUSH* > > I think we would need something like this, if only for > completeness. > > -- >8 -- > [PATCH] combine-diff: honour --no-commit-id > > Somehow we forgot to look at no_commit_id flag in these > codepaths.
It's good that I haven't started coding support for combined commitdiff in gitweb, as I would probably wonder why the code doesn't work ;-)
-- Jakub Narebski