git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] gitweb: Get rid of git_print_simplified_log

From
Jakub Narebski <jnareb@gmail.com>
Date
Oct 24, 2006, 11:52 UTC
Message-ID
<200610241352.46422.jnareb@gmail.com>
In-Reply-To
<200610241349.54685.jnareb@gmail.com>

Replace calls to git_print_simplified_log with its expansion, i.e. with calling git_print_log with appropriate options.

Remove no longer used git_print_simplified_log subroutine.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
 gitweb/gitweb.perl |   13 ++-----------
 1 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 0a7d65c..8ac60be 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1697,15 +1697,6 @@ sub git_print_log ($;%) {
 	}
 }
 
-sub git_print_simplified_log {
-	my $log = shift;
-	my $remove_title = shift;
-
-	git_print_log($log,
-		-final_empty_line=> 1,
-		-remove_title => $remove_title);
-}
-
 # print tree entry (row of git_tree), but without encompassing <tr> element
 sub git_print_tree_entry {
 	my ($t, $basedir, $hash_base, $have_blame) = @_;
@@ -2995,7 +2986,7 @@ sub git_log {
 		      "</div>\n";
 
 		print "<div class=\"log_body\">\n";
-		git_print_simplified_log($co{'comment'});
+		git_print_log($co{'comment'}, -final_empty_line=> 1);
 		print "</div>\n";
 	}
 	git_footer_html();
@@ -3365,7 +3356,7 @@ sub git_commitdiff {
 		git_print_authorship(\%co);
 		print "<div class=\"page_body\">\n";
 		print "<div class=\"log\">\n";
-		git_print_simplified_log($co{'comment'}, 1); # skip title
+		git_print_log($co{'comment'}, -final_empty_line=> 1, -remove_title => 1);
 		print "</div>\n"; # class="log"
 
 	} elsif ($format eq 'plain') {
-- 
1.4.2.1
Previous: Jakub NarebskiNext: Jakub Narebski
Message 2 of 8 in “gitweb: Improvements to commitdiff oview”
  1. 0/3 gitweb: Improvements to commitdiff oviewJakub Narebski, Oct 24, 2006
  2. 1/3 gitweb: Get rid of git_print_simplified_logJakub Narebski, Oct 24, 2006
  3. 2/3 gitweb: Filter out commit ID from @difftree in git_commit and git_commitdiffJakub Narebski, Oct 24, 2006
  4. Junio C HamanoOct 25, 2006
  5. Jakub NarebskiOct 25, 2006
  6. 4/3 gitweb: Use --no-commit-id in git_commit and git_commitdiffJakub Narebski, Oct 25, 2006
  7. 2/3 gitweb: Use --no-commit-id in git_commit and git_commitdiffJakub Narebski, Oct 25, 2006
  8. 3/3 gitweb: Print commit message without title in commitdiff only if there is anyJakub Narebski, Oct 24, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.