Re: [RFC] Syntax highlighting for combined diff

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 21, 2006, 10:02 UTC
Message-ID: <200610211202.00314.jnareb@gmail.com>
In-Reply-To: <7vfydigg4w.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 20 quoted lines

> Jakub Narebski <jnareb@gmail.com> writes:
> 
> > Do I understand code correctly, and the last '+' or '-'
> > in the parents column means?
> >
> >         for (i = 0; i < ecbdata->nparents && len; i++) {
> >                 if (line[i] == '-')
> >                         color = DIFF_FILE_OLD;
> >                 else if (line[i] == '+')
> >                         color = DIFF_FILE_NEW;
> >         }
> >
> > Anyone who wrote this code, could you answer me, please?
> 
> The "up to ecbdata->nparents" is Johannes in cd112ce.  But you
> are looking at a wrong code, I am afraid, if your original
> question was about the combined format (there is a comment about
> the codepath dealing only with two-way diffs by Johannes, above
> the part you quoted).  The output for combined diff is coming
> from combine-diff.c:dump_sline().

I was asking both about combined diff format, and how it is colored by git-diff --color, to add colored combined diff output to gitweb.

> Combined diff output logic pretty much guarantees that you never
> will see plus and minus on the same line.

That's enough for me.

Any other ideas how combined commitdiff should look like in gitweb?

-- 
Jakub Narebski
Poland