Re: git-svnimport and tags

From: Petr Baudis <pasky@suse.cz>
Date: Oct 13, 2006, 20:15 UTC
Message-ID: <20061013201537.GV20017@pasky.or.cz>
In-Reply-To: <452FA667.1060003@computing.dcu.ie>

  Hello,

Dear diary, on Fri, Oct 13, 2006 at 04:44:55PM CEST, I got a letter where Nicolas Stroppa <nstroppa@computing.dcu.ie> said that...

Show 28 quoted lines

> A small report. (I am using cogito-0.18 and git 1.4.2.3.)
> I have imported an SVN project using git-svnimport.
> This project has several tags. Here is what I get with one the tags.
> 
> tricatel $ git-cat-file tag `cat .git/refs/tags/alanis-0.9.4`
> object [...]
> type commit
> tag alanis-0.9.4
> tagger nico <nico>
> 
> 
> If I do the same thing on a git repository created from scratch, I get:
> 
> tricatel $ git-cat-file tag `cat .git/refs/tags/alanis-0.9.4`
> object [...]
> type commit
> tag alanis-0.9.4
> tagger nico <nico@[...]> 1160736694 +0100
> 
> The date information is missing in the first case, which confuses
> cg-tag-show:
> tricatel $ cg-tag-show alanis-0.9.4
> [...]
> cg-Xlib: line 215: nico <n (nic * 3600 + co> * 60):
> syntax error in expression (error token is "(nic * 3600 + co> * 60)")
> 
> I don't know if cg-tag-show should be more robust or if the date
> information should be in the tag.

  I think git-svnimport is broken here, the tagger line is clearly
defined that it must contain the time specification. And git-mktag is
broken as well since the verification of that line is a TODO so we let
the user put any garbage there.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)