git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2

From
LTLuben Tuikov <ltuikov@yahoo.com>
Date
Oct 11, 2006, 02:09 UTC
Message-ID
<20061011020903.63831.qmail@web31812.mail.mud.yahoo.com>

Commit eeef88cd2 introduced $group_size which inverted the meaning of $current_color.

Normally we start with white (same as background) color for the zebra coloring, and flip to dark shade only when another commit changed some lines of the file. (Thus if there are no changes, the file appears black on white.)

Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 173f521..77063f0 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2583,7 +2583,7 @@ sub git_blame2 {
 	git_print_page_path($file_name, $ftype, $hash_base);
 	my @rev_color = (qw(light2 dark2));
 	my $num_colors = scalar(@rev_color);
-	my $current_color = 0;
+	my $current_color = 1;
 	my $last_rev;
 	print <<HTML;
 <div class="page_body">
-- 
1.4.3.rc2.gd2a59
Next: Junio C Hamano
Message 1 of 3 in “gitweb: Fix zebra coloring flip introduced by eeef88cd2”
  1. gitweb: Fix zebra coloring flip introduced by eeef88cd2Luben Tuikov, Oct 11, 2006
  2. Junio C HamanoOct 11, 2006
  3. Luben TuikovOct 11, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.