Re: git-send-email w/ headers

From: Len Brown <len.brown@intel.com>
Date: Oct 7, 2006, 04:40 UTC
Message-ID: <200610070040.48919.len.brown@intel.com>
In-Reply-To: <7v1wpm2cxd.fsf@assigned-by-dhcp.cox.net>

On Friday 06 October 2006 02:09, Junio C Hamano wrote:

Show 11 quoted lines

> Len Brown <len.brown@intel.com> writes:
> 
> > But the Signed-off-by: line from the original message body has
> > now been swallowed up into the message header -- so my mailer
> > doesn't display it.
> 
> Sorry, what I sent out has worse breakage than not having your
> custom header.  It would eat the first paragraph of your message
> X-<.
> 
> A replacement patch is attached.

Latest patch seems to be doing the right thing (included below).

However, I've discovered another rough edge. git-send-email offers to --compose an initial message, but it doesn't pick up the .git/config header like git-format-patch does:

$ cat .git/config
[format]
        headers = Reply-To: Len Brown <lenb@kernel.org>\nOrganization: Intel Open Source Technology Center\n

thanks, -Len

Return-Path: <len.brown@intel.com>
 Received: from sccrmhc13.comcast.net (sccrmhc13.comcast.net [63.240.77.83])
        by hera.kernel.org (8.13.7/8.13.7) with ESMTP id k974Of6m010205
        for <lenb@kernel.org>; Sat, 7 Oct 2006 04:25:09 GMT
 Received: from localhost.localdomain (c-65-96-213-102.hsd1.ma.comcast.net[65.96.213.102])
          by comcast.net (sccrmhc13) with SMTP
          id <2006100704243601300452mke>; Sat, 7 Oct 2006 04:24:36 +0000
 From: Len Brown <len.brown@intel.com>
 To: lenb@kernel.org
 Cc: Len Brown <len.brown@intel.com>
 Subject: [PATCH 1/14] test: create junk
 Date: Sat,  7 Oct 2006 00:27:35 -0400
 Message-Id: <11601952702774-git-send-email-len.brown@intel.com>
 X-Mailer: git-send-email 1.4.2.3.gabd6-dirty
 In-Reply-To: <11601952681813-git-send-email-len.brown@intel.com>
 References: <11601952681813-git-send-email-len.brown@intel.com>
 Message-Id: <7488d8f01c21a6411ad99c1d16e95ecd6e1542a6.1160195250.git.len.brown@intel.com>
 Date: Wed, 4 Oct 2006 01:11:12 -0400
 Reply-To: Len Brown <lenb@kernel.org>
 Organization: Intel Open Source Technology Center
 X-Virus-Scanned: ClamAV 0.88.4/2002/Fri Oct  6 22:58:03 2006 on hera.kernel.org
 X-Virus-Status: Clean
 X-Spam-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,
        FORGED_RCVD_HELO,INVALID_DATE autolearn=no version=3.1.3
 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on hera.kernel.org
 Status: R
 X-Status: NGC
 X-KMail-EncryptionState: 
 X-KMail-SignatureState: 
 X-KMail-MDN-Sent: 
 
Signed-off-by: Len Brown <len.brown@intel.com>
---
 junk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/junk b/junk
new file mode 100644
index 0000000..9ecf3cf
--- /dev/null
+++ b/junk
@@ -0,0 +1 @@
+this

-- 
1.4.2.3.gabd6-dirty