git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Make git-send-email detect mbox-style patches more readily

From
MWMatthew Wilcox <matthew@wil.cx>
Date
Oct 6, 2006, 20:24 UTC
Message-ID
<20061006202414.GR2563@parisc-linux.org>

Earlier today, I embarrassed myself by trying to construct a patch that git-send-email would send, and I missed out the putting

>From garbage
line on the front, which led it to send the patches with a
Subject: From: Matthew Wilcox <matthew@wil.cx>
line.  Bad.

This patch makes git-send-email detect an mbox-style file more readily, and correctly handles the patches I constructed.

--- git-core-willy/git-send-email.perl 2006-07-24 23:45:08.000000000 -0400 +++ git-core-1.4.1.1/git-send-email.perl 2006-10-06 16:02:37.000000000 -0400

@@ -451,6 +451,7 @@
 		if (!$header_done) {
 			$found_mbox = 1, next if (/^From /);
 			chomp;
+			$found_mbox = 1 if (/^(From|Date|Cc|Subject):/);
 
 			if ($found_mbox) {
 				if (/^Subject:\s+(.*)$/) {
Next: Junio C Hamano
Message 1 of 2 in “Make git-send-email detect mbox-style patches more readily”
  1. Matthew WilcoxOct 6, 2006
  2. Junio C HamanoOct 7, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.