git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: perhaps time to remove git_blame from gitweb, and git-annotate?

From
LTLuben Tuikov <ltuikov@yahoo.com>
Date
Oct 6, 2006, 20:21 UTC
Message-ID
<20061006202101.41031.qmail@web31804.mail.mud.yahoo.com>
In-Reply-To
<20061006190850.GA4827@pasky.or.cz>
--- Petr Baudis <pasky@suse.cz> wrote:
Show 33 quoted lines
> (Trimmed cc list to people caring about gitweb.)
> 
> Dear diary, on Fri, Oct 06, 2006 at 08:55:29PM CEST, I got a letter
> where Luben Tuikov <ltuikov@yahoo.com> said that...
> > --- Petr Baudis <pasky@suse.cz> wrote:
> > > I will not mourn git-annotate disappearance (perhaps it could stay an
> > > alias to git-blame -c; I don't like this UI-wise but we already do this
> > > kind of thing with git-log / git-whatchanged). I still like gitweb blame
> > > better than blame2 but I'll just patch blame to look like blame2 (or
> > > better) and be happy with that.
> > 
> > That's exactly what I don't want to happen.  blame2 is much less
> > bloated than blame both in code and in visual appearance and in using
> > git.  And this was the whole point: quick, short, fast and straight
> > to the point.
> > 
> > I'd like to keep the blame interface as simple as possible, more
> > window estate given to the code lines, and as little as possible to
> > the commit id: a clickable commit-8 and now we also have clickable
> > line_no to show us the state of the file, is more than enough.
> > 
> > So far, blame2 has been by far the better "annotate" (as it is called
> > in the other SCMs) interface I've seen in four other SCMs (some proprietary).
> > Let's keep it like this.
> > 
> > When data-mining code, what I'm interested in is: where did this line
> > of code come from (commit-8), is it a part of a larger chunk (zebra
> > coloring) and how it relates to the surrounding code.  Blame2 is more
> > than efficient at this.
> 
> And _I_ like to have some general idea about who and when touched given
> line of code, without having to click on a bunch of commit ids or spend
> a minute hovering over them patiently. ;-)
Well understood.

Although, when I'm chasing after a problem, I care much about tracing back through the commit history as opposed to who did what and when, not until I've nailed the regressive commit (is when I care who/what/when/how).

Show 6 quoted lines
> If you really feel strongly about it, we should be able to make the
> individual columns hideable at view time, e.g. by a tiny bit of
> javascript just changing the display CSS property, which would be really
> comfortable. My idea about the output would be cg-log -s format, which
> is still reasonably tense. OTOH, there's still some space to burn in the
> Line column.
Point taken.

Now since I don't want to turn blame2 into a circus, and since the whole point of blame2 (over blame) was to stay away from it being a circus, and to be fast and to the point, can we just keep git_blame() around which gives you this extra information right in the main screen?

    Luben
P.S. The alternative is to create a next git_blame{N+1}() each time
git_blameN() becomes git_blame{N-1}().
Previous: Petr BaudisNext: Ryan Anderson
Message 11 of 14 in “gitweb: blame: Print just a single new line char per table row”
  1. 1/2 gitweb: blame: Print just a single new line char per table rowLuben Tuikov, Oct 5, 2006
  2. Junio C HamanoOct 5, 2006
  3. Luben TuikovOct 5, 2006
  4. perhaps time to remove git_blame from gitweb, and git-annotate?Junio C Hamano, Oct 5, 2006
  5. Johannes SchindelinOct 6, 2006
  6. Luben TuikovOct 6, 2006
  7. Martin Langhoff (CatalystIT)Oct 7, 2006
  8. Petr BaudisOct 6, 2006
  9. Luben TuikovOct 6, 2006
  10. Petr BaudisOct 6, 2006
  11. Luben TuikovOct 6, 2006
  12. 1/1 Remove git-annotate.perl and create a builtin-alias for git-blameRyan Anderson, Oct 9, 2006
  13. Ryan AndersonOct 9, 2006
  14. Obituary for git-annotateJunio C Hamano, Oct 9, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.