git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http/ftp: optionally ask curl to not use EPSV command

From
SKSasha Khapyorsky <sashak@voltaire.com>
Date
Sep 29, 2006, 00:07 UTC
Message-ID
<20060929000754.GK10617@sashak.voltaire.com>
In-Reply-To
<7vejtvu1ja.fsf@assigned-by-dhcp.cox.net>
On 14:25 Thu 28 Sep     , Junio C Hamano wrote:
Show 36 quoted lines
> Sasha Khapyorsky <sashak@voltaire.com> writes:
> 
> > If GIT_CURL_FTP_NO_EPSV environment variable is defined, disable using
> > of EPSV ftp command (PASV will be used instead). This is helpful with
> > some "poor" ftp servers which doesn't support EPSV mode.
> >
> > Signed-off-by: Sasha Khapyorsky <sashak@voltaire.com>
> > ---
> >  http.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/http.c b/http.c
> > index 6c1937b..a966e6d 100644
> > --- a/http.c
> > +++ b/http.c
> > @@ -196,6 +196,9 @@ #endif
> >  
> >  	curl_easy_setopt(result, CURLOPT_USERAGENT, GIT_USER_AGENT);
> >  
> > +	if (getenv("GIT_CURL_FTP_NO_EPSV"))
> > +		curl_easy_setopt(result, CURLOPT_FTP_USE_EPSV, 0);
> > +
> >  	return result;
> >  }
> >  
> > -- 
> > 1.4.2.1
> 
> Care to match this with existing ones?
> 
> $ git grep -e GIT_CURL -e GIT_SSL -e GIT_HTTP
> 
> tells you how they are handled and documented.  If you spot
> inconsistencies if any (e.g. some having config entry and some
> only environment -- I haven't checked), correcting them while
> you are at it might be a good thing as well.
Make sense. Will rework.
Sasha
Previous: Junio C HamanoNext: Sasha Khapyorsky
Message 3 of 5 in “http/ftp: optionally ask curl to not use EPSV command”
  1. http/ftp: optionally ask curl to not use EPSV commandSasha Khapyorsky, Sep 28, 2006
  2. Junio C HamanoSep 28, 2006
  3. Sasha KhapyorskySep 29, 2006
  4. http/ftp: optionally ask curl to not use EPSV commandSasha Khapyorsky, Sep 29, 2006
  5. Jakub NarebskiOct 3, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.