git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] cg-commit: fix signed off handling

From
Petr Baudis <pasky@suse.cz>
Date
Sep 24, 2006, 20:05 UTC
Message-ID
<20060924200505.GY20017@pasky.or.cz>
In-Reply-To
<20060924183246.GA695@diku.dk>

Dear diary, on Sun, Sep 24, 2006 at 08:32:46PM CEST, I got a letter where Jonas Fonseca <fonseca@diku.dk> said that...

Show 19 quoted lines
> Petr Baudis <pasky@suse.cz> wrote Sun, Sep 24, 2006:
> > diff --git a/cg-commit b/cg-commit
> > index 43e6c6c..beedb6f 100755
> > --- a/cg-commit
> > +++ b/cg-commit
> > @@ -402,10 +402,6 @@ if [ "$msgfile" ]; then
> >  	written=1
> >  fi
> >  
> > -# Always have at least one blank line, to ease the editing for
> > -# the poor people whose text editor has no 'O' command.
> > -[ "$written" ] || { tty -s && echo >>"$LOGMSG"; }
> > -
> >  add_signoff() {
> >  	if [ "$signoff" ] && ! grep -q -i "signed-off-by: $signoff" $LOGMSG; then
> >  		grep -q -i sign-off-by $LOGMSG || echo
> 			   ^^^^^^^^^^^
> 
> My patch also fixed this to grep for "signed-off-by".
Oh, thanks - fixed.
-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)
Previous: Jonas Fonseca
Message 4 of 4 in “cg-commit: fix signed off handling”
  1. cg-commit: fix signed off handlingJonas Fonseca, Aug 25, 2006
  2. Petr BaudisSep 24, 2006
  3. Jonas FonsecaSep 24, 2006
  4. Petr BaudisSep 24, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.