Re: [PATCH] add receive.denyNonFastforwards config variable
- From
Jeff King <peff@peff.net>
- Date
- Sep 20, 2006, 23:45 UTC
- Message-ID
- <20060920234548.GA20461@coredump.intra.peff.net>
- In-Reply-To
- <Pine.LNX.4.63.0609210107140.19042@wbgn013.biozentrum.uni-wuerzburg.de>
On Thu, Sep 21, 2006 at 01:07:54AM +0200, Johannes Schindelin wrote:
Show 14 quoted lines
> + if (deny_non_fast_forwards && !is_null_sha1(old_sha1)) {
> + struct commit *old_commit, *new_commit;
> + struct commit_list *bases;
> +
> + old_commit = (struct commit *)parse_object(old_sha1);
> + new_commit = (struct commit *)parse_object(new_sha1);
> + for (bases = get_merge_bases(old_commit, new_commit, 1);
> + bases; bases = bases->next)
> + if (!hashcmp(old_sha1, bases->item->object.sha1))
> + break;
> + if (!bases)
> + return error("denying non-fast forward;"
> + " you should pull first");
> + }Memory leak on 'bases'. It shouldn't matter much because the program is short-lived, but I couldn't remember if we have a policy on such things with increasing lib-ification.
-Peff