git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] rev-list: fix segfault with --{author,committer,grep}

From
Jeff King <peff@peff.net>
Date
Sep 18, 2006, 06:52 UTC
Message-ID
<20060918065242.GA13691@coredump.intra.peff.net>
In-Reply-To
<7v4pv6yphp.fsf@assigned-by-dhcp.cox.net>
We need to save the commit buffer if we're going to match against it.
Signed-off-by: Jeff King <peff@peff.net>
---
 builtin-rev-list.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/builtin-rev-list.c b/builtin-rev-list.c
index 1f3333d..dbfee75 100644
--- a/builtin-rev-list.c
+++ b/builtin-rev-list.c
@@ -269,7 +269,9 @@ int cmd_rev_list(int argc, const char **
 	    revs.diff)
 		usage(rev_list_usage);
 
-	save_commit_buffer = revs.verbose_header;
+	save_commit_buffer = revs.verbose_header ||
+		revs.header_filter ||
+		revs.message_filter;
 	track_object_refs = 0;
 	if (bisect_list)
 		revs.limited = 1;
-- 
1.4.2.1.g9f1c-dirty
Previous: Linus Torvalds
Message 5 of 5 in “revision traversal: --author, --committer, and --grep.”
  1. 3/3 revision traversal: --author, --committer, and --grep.Junio C Hamano, Sep 18, 2006
  2. Jeff KingSep 18, 2006
  3. Junio C HamanoSep 18, 2006
  4. Linus TorvaldsSep 18, 2006
  5. rev-list: fix segfault with --{author,committer,grep}Jeff King, Sep 18, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.