Re: [PATCH 2/2] Handle invalid argc gently

From: Dmitry V. Levin <ldv@altlinux.org>
Date: Sep 14, 2006, 18:25 UTC
Message-ID: <20060914182539.GA12109@basalt.office.altlinux.org>
In-Reply-To: <7virjq4cfj.fsf@assigned-by-dhcp.cox.net>

On Thu, Sep 14, 2006 at 09:53:36AM -0700, Junio C Hamano wrote: [...]

Show 10 quoted lines

> >> What is the valid reason to do execlp("git", NULL, NULL)?
> >
> > Personally I do not plan to execute git this way on regular basis, indeed. :)
> >
> > But argc == 0 is allowed, so why should git crash?
> 
> Oh, no I was not arguing for making git crash.  I was just
> trying to learn if there is a valid reason to choose to, or
> common misconfiguration that causes it to, run with ac == 0,
> since I did not think of any.

Well, the execlp example is somewhat dragged in. More common case is execvp:

char *argv[] = { NULL }; execvp("git", argv);

The argv array may be empty for various reasons, e.g. pointer arithmetic mistakes.

-- 
ldv