git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: reset input record separator in parse_commit even on error

From
SVSven Verdoolaege <skimo@liacs.nl>
Date
Sep 9, 2006, 15:12 UTC
Message-ID
<20060909151236.GA25518@liacs.nl>

--- This probably never happens, but just in case...

 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 7afdf33..60dd598 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -897,8 +897,8 @@ sub parse_commit {
 		my $fd = git_pipe("rev-list", "--header", "--parents", "--max-count=1", $commit_id)
 			or return;
 		@commit_lines = split '\n', <$fd>;
-		close $fd or return;
 		$/ = "\n";
+		close $fd or return;
 		pop @commit_lines;
 	}
 	my $header = shift @commit_lines;
-- 
0.99.8c.g64e8-dirty
Next: Jeff King
Message 1 of 3 in “gitweb: reset input record separator in parse_commit even on error”
  1. gitweb: reset input record separator in parse_commit even on errorSven Verdoolaege, Sep 9, 2006
  2. Jeff KingSep 9, 2006
  3. Jakub NarebskiSep 9, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.