git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] autoconf: Set NO_ICONV if iconv is found neither in libc, nor in libiconv

From
Jakub Narebski <jnareb@gmail.com>
Date
Sep 7, 2006, 11:48 UTC
Message-ID
<200609071348.08808.jnareb@gmail.com>
In-Reply-To
<200609071347.32152.jnareb@gmail.com>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
This patch only adds NO_ICONV=YesPlease, and it never unsets
NO_ICONV. This doesn't matter now because there is no setting
NO_ICONV value in Makefile (no architecture/system based detection).
 configure.ac |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 482c849..8af276c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -143,9 +143,12 @@ AC_CHECK_LIB([expat], [XML_ParserCreate]
 AC_SUBST(NO_EXPAT)
 #
 # Define NEEDS_LIBICONV if linking with libc is not enough (Darwin).
+# Define NO_ICONV if neither libc nor libiconv support iconv.
 AC_CHECK_LIB([c], [iconv],
-[NEEDS_LIBICONV=],
-[NEEDS_LIBICONV=YesPlease])
+	[NEEDS_LIBICONV=],
+	AC_CHECK_LIB([iconv], [iconv],
+		[NEEDS_LIBICONV=YesPlease],
+		[GIT_CONF_APPEND_LINE([NO_ICONV=YesPlease])]))
 AC_SUBST(NEEDS_LIBICONV)
 test -n "$NEEDS_LIBICONV" && LIBS="$LIBS -liconv"
 #
-- 
1.4.2
Previous: Jakub NarebskiNext: Jakub Narebski
Message 2 of 3 in “autoconf: iconv”
  1. 0/2 autoconf: iconvJakub Narebski, Sep 7, 2006
  2. 1/2 autoconf: Set NO_ICONV if iconv is found neither in libc, nor in libiconvJakub Narebski, Sep 7, 2006
  3. 2/2 autoconf: Add support for setting NO_ICONV and ICONVDIRJakub Narebski, Sep 7, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.