git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix memory leak in "connect.c".

From
Christian Couder <chriscool@tuxfamily.org>
Date
Sep 7, 2006, 03:59 UTC
Message-ID
<20060907055952.dafffe2b.chriscool@tuxfamily.org>
sq_quote allocates some memory that should be freed.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 connect.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/connect.c b/connect.c
index 1c6429b..40a1c28 100644
--- a/connect.c
+++ b/connect.c
@@ -697,8 +697,9 @@ int git_connect(int fd[2], char *url, co
 	if (pid < 0)
 		die("unable to fork");
 	if (!pid) {
-		snprintf(command, sizeof(command), "%s %s", prog,
-			 sq_quote(path));
+		char *sq_path = sq_quote(path);
+		snprintf(command, sizeof(command), "%s %s", prog, sq_path);
+		free(sq_path);
 		dup2(pipefd[1][0], 0);
 		dup2(pipefd[0][1], 1);
 		close(pipefd[0][0]);
-- 
1.4.2.g1ccae49
Next: Junio C Hamano
Message 1 of 6 in “Fix memory leak in "connect.c".”
  1. Fix memory leak in "connect.c".Christian Couder, Sep 7, 2006
  2. Junio C HamanoSep 7, 2006
  3. 0/2 Command preparation cleanup in "connect.c" (was: [PATCH] Fix memory leak in "connect.c".)Christian Couder, Sep 11, 2006
  4. 1/2 Move add_to_string to "quote.c" and make it extern.Christian Couder, Sep 11, 2006
  5. 2/2 Fix a memory leak in "connect.c" and die if command too long.Christian Couder, Sep 11, 2006
  6. Junio C HamanoSep 11, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.