Re: [PATCH] git-svnimport: Parse log message for Signed-off-by: lines

From: Sasha Khapyorsky <sashak@voltaire.com>
Date: Sep 5, 2006, 22:17 UTC
Message-ID: <20060905221754.GI14732@sashak.voltaire.com>
In-Reply-To: <7v1wqqc8dh.fsf@assigned-by-dhcp.cox.net>

On 14:26 Tue 05 Sep     , Junio C Hamano wrote:

Show 21 quoted lines

> Sasha Khapyorsky <sashak@voltaire.com> writes:
> 
> > Hi,
> >
> > This feature was useful with importing https://openib.org/svn/gen2 .
> >
> > Sasha
> >
> > This add '-S' option. When specified svn-import will try to parse
> > commit message for 'Signed-off-by: ...' line, and if found will use
> > the name and email address extracted at first occurrence as this commit
> > author name and author email address. Committer name and email are
> > extracted in usual way.
> >
> > Signed-off-by: Sasha Khapyorsky <sashak@voltaire.com>
> 
> Thanks.
> 
> I do not think the first signed-off-by is necessarily the author
> of the change, so we are risking miscrediting (or misblaming) a
> wrong person.

Right, there is such risk, so this feature is optional and by default is "off".

Show 6 quoted lines

> Having said that, using the committer information
> has the same miscredit problem, so this change might be Ok, but
> I am not sure if it adds much improvement.
> 
> I will wait for an ack/nack from somebody who use svnimport and
> know it well.

Sure.

BTW, what about to importing subdirectories, like this:

 <trunk>/path/to/subdir
 <branches>/path/to/subdir

Is this could be improvement?

Show 22 quoted lines

> 
> BTW, I do not appreciate the first six lines of your message
> being _before_ the proposed commit log message.  Please have it
> between "---\n" (that comes immediately after your own
> "Signed-off-by:") and the diffstat, like this:
> 
>         This add '-S' option. When specified svn-import will try to...
>         ... in usual way.
> 
>         Signed-off-by: Sasha Khapyorsky <sashak@voltaire.com>
>         ---
> 
>           Hi,
> 
>           This feature was useful with importing https://openib.org/svn/gen2 .
> 
>           Sasha
> 
>          git-svnimport.perl |   31 ++++++++++++++++++++-----------
>          1 files changed, 20 insertions(+), 11 deletions(-)
> 
>          diff --git a/...

Ok.

Sasha