git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/5] autoconf: Add -liconv to LIBS when NEEDS_LIBICONV

From
Jonas Fonseca <fonseca@diku.dk>
Date
Sep 5, 2006, 16:25 UTC
Message-ID
<20060905162526.GA5547@diku.dk>
In-Reply-To
<200609050055.52980.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> wrote Tue, Sep 05, 2006:
Show 17 quoted lines
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> Just in case; it could matter for testing if iconv is properly
> supported (NO_ICONV test).
> 
>  configure.ac |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 36f9cd9..fc5b813 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -147,6 +147,7 @@ AC_CHECK_LIB([c], [iconv],
>  [NEEDS_LIBICONV=],
>  [NEEDS_LIBICONV=YesPlease])
>  AC_SUBST(NEEDS_LIBICONV)
> +test -n "$NEEDS_SOCKET" && LIBS="$LIBS -liconv"

I see that this has entered already, but it looks like it needs a s/NEEDS_SOCKET/NEEDS_LIBICONV/

>  #
>  # Define NEEDS_SOCKET if linking with libc is not enough (SunOS,
>  # Patrick Mauritz).
-- 
Jonas Fonseca
Previous: Jakub NarebskiNext: Jakub Narebski
Message 4 of 19 in “Some autoconf patches”
  1. 0/5 Some autoconf patchesJakub Narebski, Sep 4, 2006
  2. 1/5 autoconf: Add some commented out variables to config.mak.inJakub Narebski, Sep 4, 2006
  3. 2/5 autoconf: Add -liconv to LIBS when NEEDS_LIBICONVJakub Narebski, Sep 4, 2006
  4. Jonas FonsecaSep 5, 2006
  5. autoconf: Fix copy'n'paste errorJakub Narebski, Sep 5, 2006
  6. Junio C HamanoSep 5, 2006
  7. 3/5 autoconf: Preliminary check for working mmapJakub Narebski, Sep 4, 2006
  8. Junio C HamanoSep 4, 2006
  9. Jakub NarebskiSep 4, 2006
  10. Shawn PearceSep 5, 2006
  11. Junio C HamanoSep 5, 2006
  12. Shawn PearceSep 5, 2006
  13. Junio C HamanoSep 5, 2006
  14. Shawn PearceSep 6, 2006
  15. Junio C HamanoSep 6, 2006
  16. Junio C HamanoSep 6, 2006
  17. Shawn PearceSep 7, 2006
  18. 4/5 autoconf: Check for subprocess.pyJakub Narebski, Sep 4, 2006
  19. 5/5 autoconf: Quote AC_CACHE_CHECK argumentsJakub Narebski, Sep 4, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.