Re: [PATCH 2/2] Look for a commit's parents in the standard way.

From: Yann Dirson <dwitch@nan92-1-81-57-214-146.fbx.proxad.net>
Date: Sep 3, 2006, 19:36 UTC
Message-ID: <20060903193650.GA4914@nan92-1-81-57-214-146.fbx.proxad.net>
In-Reply-To: <b0943d9e0608200343t517ec29dw2b6b49d9d69dbad5@mail.gmail.com>

On Sun, Aug 20, 2006 at 11:43:22AM +0100, Catalin Marinas wrote:

Show 6 quoted lines

> On 14/08/06, Yann Dirson <ydirson@altern.org> wrote:
> >This has the direct effect of taking info/grafts into account, since
> >ignoring it only causes confusion.
> 
> I don't know the difference but is there any between parsing the
> commit file and using git-rev-list --parents?

Yes, git-rev-list at least takes info/grafts into account.

Show 7 quoted lines

> >+        self.__parents = split(_output_lines('git-rev-list --parents 
> >--max-count=1 %s' % id_hash)[0])[1:]
> 
> Instead of using the split() method, you could call
> _output_lines('git-rev-list --parents --max-count=1 %s' %
> id_hash)[0].split()[1:]. Maybe that's why they might deprecate the
> global split method.

Ah, OK.

Best regards,

-- 
Yann.

-- 
VGER BF report: U 0.500235