git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Remove forgotten call to git_to_hash

From
DSDennis Stosberg <dennis@stosberg.net>
Date
Aug 31, 2006, 19:32 UTC
Message-ID
<20060831193245.G22a7ca6b@leonov.stosberg.net>
In-Reply-To
<7vac5px1ic.fsf@assigned-by-dhcp.cox.net>

On Aug 27th, Jakub Narebski sent a patch which removed the git_to_hash() function and this call to it. The patch did not apply cleanly and had to be applied manually. Removing the last chunk has obviously been forgotten.

See: commit  0aea33762b1262d11fb43eda9f3fc152b5622cca and
     message <200608272345.26722.jnareb@gmail.com>
Signed-off-by: Dennis Stosberg <dennis@stosberg.net>
---
 gitweb/gitweb.perl |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 9324d71..68f40bd 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2778,10 +2778,6 @@ sub git_blobdiff {
 			@difftree
 				or die_error('404 Not Found', "Blob diff not found");
 
-		} elsif (defined $hash) { # try to find filename from $hash
-			if ($hash !~ /[0-9a-fA-F]{40}/) {
-				$hash = git_to_hash($hash);
-			}
 		} elsif (defined $hash &&
 		         $hash =~ /[0-9a-fA-F]{40}/) {
 			# try to find filename from $hash
-- 
1.4.2
Previous: Junio C Hamano
Message 5 of 5 in “gitweb: Get rid of failed experiments ;-)”
  1. 0/2 gitweb: Get rid of failed experiments ;-)Jakub Narebski, Aug 27, 2006
  2. 1/2 gitweb: Remove unused git_get_{preceding,following}_referencesJakub Narebski, Aug 27, 2006
  3. 2/2 gitweb: Remove git_to_hash functionJakub Narebski, Aug 27, 2006
  4. Junio C HamanoAug 27, 2006
  5. gitweb: Remove forgotten call to git_to_hashDennis Stosberg, Aug 31, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.