git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] use do() instead of require() to include configuration

From
DSDennis Stosberg <dennis@stosberg.net>
Date
Aug 29, 2006, 07:19 UTC
Message-ID
<20060829071902.G648e8860@leonov.stosberg.net>
In-Reply-To
<11567801982990-git-send-email-jnareb@gmail.com>

When run under mod_perl, require() will read and execute the configuration file on the first invocation only. On every subsequent invocation, all configuration variables will be reset to their default values. do() reads and executes the configuration file unconditionally.

Signed-off-by: Dennis Stosberg <dennis@stosberg.net>
---
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 352236b..39ebcf4 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -152,7 +152,7 @@ # - one might want to include '-B' optio
 our @diff_opts = ('-M'); # taken from git_commit
 
 our $GITWEB_CONFIG = $ENV{'GITWEB_CONFIG'} || "++GITWEB_CONFIG++";
-require $GITWEB_CONFIG if -e $GITWEB_CONFIG;
+do $GITWEB_CONFIG if -e $GITWEB_CONFIG;
 
 # version of the core git binary
 our $git_version = qx($GIT --version) =~ m/git version (.*)$/ ? $1 : "unknown";
-- 
1.4.2
Previous: Dennis StosbergNext: Jakub Narebski
Message 7 of 12 in “Running gitweb under mod_perl”
  1. Jakub NarebskiAug 24, 2006
  2. Johannes SchindelinAug 24, 2006
  3. Dennis StosbergAug 24, 2006
  4. gitweb: Use --git-dir parameter instead of setting $ENV{'GIT_DIR'}Dennis Stosberg, Aug 24, 2006
  5. gitweb: Use --git-dir parameter instead of setting $ENV{'GIT_DIR'}Jakub Narebski, Aug 28, 2006
  6. Dennis StosbergAug 29, 2006
  7. use do() instead of require() to include configurationDennis Stosberg, Aug 29, 2006
  8. Jakub NarebskiSep 5, 2006
  9. Jakub NarebskiAug 24, 2006
  10. Dennis StosbergAug 24, 2006
  11. Jakub NarebskiAug 24, 2006
  12. Randal L. SchwartzAug 25, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.