Re: [PATCH] git-send-email: Don't set author_not_sender from Cc: lines

From: Haavard Skinnemoen <hskinnemoen@atmel.com>
Date: Aug 23, 2006, 09:14 UTC
Message-ID: <20060823111419.22d92f51@cad-250-152.norway.atmel.com>
In-Reply-To: <7vd5asjkvb.fsf@assigned-by-dhcp.cox.net>

On Tue, 22 Aug 2006 18:34:16 -0700 Junio C Hamano <junkio@cox.net> wrote:

> The patch looks wrong.  If your name is on CC: and you want to
> suppress sending to yourself what happens?

It will still send it to you, I guess. The documentation only mentions what happens with From: lines, so I wasn't really sure what behaviour is expected...

> How about doing something like this instead?

Yeah, that's probably better. I just tested it by sending a mail to myself, and it doesn't append an extra From: line, so it solves the problem as far as I'm concerned.

Haavard

Show 15 quoted lines

> diff --git a/git-send-email.perl b/git-send-email.perl
> index a83c7e9..8adb6b9 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -510,7 +510,7 @@ foreach my $t (@files) {
>  					if ($2 eq $from) {
>  						next if
> ($suppress_from); }
> -					else {
> +					elsif ($1 eq 'From') {
>  						$author_not_sender =
> $2; }
>  					printf("(mbox) Adding cc: %s
> from line '%s'\n",
>