git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-mv: succeed even if source is a prefix of destination

From
Fredrik Kuivinen <freku045@student.liu.se>
Date
Aug 16, 2006, 19:22 UTC
Message-ID
<20060816192254.GA9575@c165.ib.student.liu.se>
In-Reply-To
<Pine.LNX.4.63.0608161041300.28360@wbgn013.biozentrum.uni-wuerzburg.de>
On Wed, Aug 16, 2006 at 10:44:02AM +0200, Johannes Schindelin wrote:
Show 23 quoted lines
> > 
> > It looks like we need some kind of path normalization before we do
> > those tests.
> 
> I kind of hoped it was not necessary to do this, since get_pathspec() does 
> a rudimentary version of it (BTW git-mv.perl got it wrong: it substituted 
> "./" by "", which would fail for a directory name like "endsWithADot.").
> 
> It was a little more involved:
> 
> -- 8< --
> [PATCH] git-mv: add more path normalization
> 
> We already use the normalization from get_pathspec(), but now we also
> remove a trailing slash. So,
> 
> 	git mv some_path/ into_some_path/
> 
> works now.
> 
> Also, move the "can not move directory into itself" test before the
> subdirectory expansion.
> 
It works as expected now. Thanks!
- Fredrik
Previous: Johannes Schindelin
Message 7 of 7 in “git-mv is broken in master”
  1. Fredrik KuivinenAug 15, 2006
  2. David RientjesAug 15, 2006
  3. git-mv: succeed even if source is a prefix of destinationJohannes Schindelin, Aug 16, 2006
  4. Fredrik KuivinenAug 16, 2006
  5. Johannes SchindelinAug 16, 2006
  6. Johannes SchindelinAug 16, 2006
  7. Fredrik KuivinenAug 16, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.