Re: diff machinery cleanup

From: Jeff King <peff@peff.net>
Date: Aug 10, 2006, 20:10 UTC
Message-ID: <20060810201049.GA4759@sigio.intra.peff.net>
In-Reply-To: <7vzmecv7tp.fsf@assigned-by-dhcp.cox.net>

On Thu, Aug 10, 2006 at 10:06:42AM -0700, Junio C Hamano wrote:

> No, run_diff_index munges the index in-core, and it does not
> writes it out for obvious reasons.

Ah, OK, that makes more sense. Is there any reason then that this
wouldn't work (it certainly seems to, but I don't want to be causing
invisible problems that will come back later)? You seemed to outline a
much more complex procedure in your original mail.
  run_diff_index();
  discard_cache();
  ...
  run_diff_files();

I'd like to go with this simple solution at first for the C runstatus, and then hopefully move to simultaneous diffing later.

-Peff