git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] autoconf: Error out on --without-shell and --without-perl

From
Jakub Narebski <jnareb@gmail.com>
Date
Aug 8, 2006, 16:36 UTC
Message-ID
<200608081836.21614.jnareb@gmail.com>
In-Reply-To
<200608081834.09271.jnareb@gmail.com>

Error out on --without-shell/--with-shell=no and --without-perl/--with-perl=no instead of just warning and continuing.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
It's a matter of taste (and not doing unexpected)
 configure.ac |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure.ac b/configure.ac
index e2da891..c2ddd9b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -37,7 +37,7 @@ # Used by GIT_ARG_SET_PATH(PROGRAM)
 AC_DEFUN([GIT_CONF_APPEND_PATH],
 [PROGRAM=m4_toupper($1); \
 if test "$withval" = "no"; then \
-	AC_MSG_WARN([You cannot use git without $1]); \
+	AC_MSG_ERROR([You cannot use git without $1]); \
 else \
 	if test "$withval" = "yes"; then \
 		AC_MSG_WARN([You should provide path for --with-$1=PATH]); \
-- 
1.4.1.1
Previous: Jakub NarebskiNext: Jakub Narebski
Message 4 of 15 in “autoconf: Some improvements”
  1. 0/4 autoconf: Some improvementsJakub Narebski, Aug 8, 2006
  2. 1/4 autoconf: Add configure target to main MakefileJakub Narebski, Aug 8, 2006
  3. 5/4 autoconf: Mention "make configure" instead of "autoconf" in INSTALLJakub Narebski, Aug 8, 2006
  4. 2/4 autoconf: Error out on --without-shell and --without-perlJakub Narebski, Aug 8, 2006
  5. 3/4 autoconf: Improvements in NO_PYTHON/PYTHON_PATH handlingJakub Narebski, Aug 8, 2006
  6. 4/4 autoconf: Move variables which we always set to config.mak.inJakub Narebski, Aug 8, 2006
  7. 6/4 autoconf: Add forgotten NO_OPENSSL=@NO_OPENSSL@ to config.mak.inJakub Narebski, Aug 8, 2006
  8. autoconf: clean temporary file mak.appendJunio C Hamano, Aug 8, 2006
  9. Jakub NarebskiAug 8, 2006
  10. Junio C HamanoAug 8, 2006
  11. autoconf: Add support for setting CURLDIR, OPENSSLDIR, EXPATDIRJakub Narebski, Aug 9, 2006
  12. Jakub NarebskiAug 10, 2006
  13. Junio C HamanoAug 10, 2006
  14. Jakub NarebskiAug 10, 2006
  15. autoconf: It is --without-python, not --no-pythonJakub Narebski, Aug 9, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.