Re: [PATCH] git-status: colorize status output
- From
Jeff King <peff@peff.net>
- Date
- Aug 5, 2006, 19:45 UTC
- Message-ID
- <20060805194513.GA4836@sigio.intra.peff.net>
- In-Reply-To
- <20060805105953.GA5410@moooo.ath.cx>
On Sat, Aug 05, 2006 at 12:59:53PM +0200, Matthias Lederhofer wrote:
> Perhaps the default values should not use the same color twice? I'd > suggest yellow for changed but not updated. But well, it's no problem > to change this in my config, I just find it a bit confusing to have > the same color for different things.
I'm fine with changing the defaults as you suggest. It makes more sense to me with only two colors (files is a potential mistake or not), but I added more fine-grained support because it was trivial and I thought others might want to customize it.
We could, of course, allow even more fine-grained control by matching file type (added, deleted, modified, etc), but I'm not sure anybody would want that.
> Is there any way to do isatty() from shell scripts?
As Junio said, test -t. :) Is there interest in me adding that feature?
-Peff