Re: Unanticipated test error

From: Peter Eriksen <s022018@student.dtu.dk>
Date: Jul 21, 2006, 08:19 UTC
Message-ID: <20060721081954.GA29645@bohr.gbar.dtu.dk>
In-Reply-To: <81b0412b0607210022o562ac326wd149c73cc529f239@mail.gmail.com>

On Fri, Jul 21, 2006 at 09:22:44AM +0200, Alex Riesen wrote: ...

Show 10 quoted lines

> Well, there are differences. Correct translation from memcpy
> to strlcpy (aside the fact with \0 inside the string) would be
> something like:
> 
>  strlcpy(to, from, len + 1);
> 
> assuming your example with memcpy. strlcpy expects size of
> storage, and will never write more bytes that it was allowed to.
> That'll cut off last character of the source string, unless it is
> \0-terminated before the size of storage.

I see it now. What I did was wrong. Appending " + 1" to every one of my calls makes the patch survive "make test". However, since strlcpy() calls strlen(from), it would have to be checked, that 'from' is always NUL terminated. The benefits of this patch seem to shrink.

Thank you for your comment!

Peter