git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-cvsexportcommit dies on merge commits

From
PBPeter Baumann <siprbaum@stud.informatik.uni-erlangen.de>
Date
Jul 5, 2006, 13:25 UTC
Message-ID
<20060705132504.GA3470@xp.machine.xx>
Signed-off-by: Peter Baumann <siprbaum@stud.informatik.uni-erlangen.de>
---
 git-cvsexportcommit.perl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl
index d1051d0..5dcb2f9 100755
--- a/git-cvsexportcommit.perl
+++ b/git-cvsexportcommit.perl
@@ -63,15 +63,15 @@ foreach my $p (@commit) {
 }
 
 if ($parent) {
+    my $found;
     # double check that it's a valid parent
     foreach my $p (@parents) {
-	my $found;
 	if ($p eq $parent) {
 	    $found = 1;
 	    last;
 	}; # found it
-	die "Did not find $parent in the parents for this commit!";
     }
+    die "Did not find $parent in the parents for this commit!" if !$found;
 } else { # we don't have a parent from the cmdline...
     if (@parents == 1) { # it's safe to get it from the commit
 	$parent = $parents[0];
-- 
1.4.0
Message 1 of 1 in “git-cvsexportcommit dies on merge commits”
  1. git-cvsexportcommit dies on merge commitsPeter Baumann, Jul 5, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.