Re: [PATCH 7/7] Convert git-annotate to use Git.pm
- From
- Ryan Anderson <ryan@michonline.com>
- Date
- Jun 25, 2006, 09:27 UTC
- Message-ID
- <20060625092719.GH3154@h4x0r5.com>
- In-Reply-To
- <20060625015434.29906.23422.stgit@machine.or.cz>
On Sun, Jun 25, 2006 at 03:54:34AM +0200, Petr Baudis wrote:
Show 26 quoted lines
> -sub open_pipe {
> - if ($^O eq '##INSERT_ACTIVESTATE_STRING_HERE##') {
> - return open_pipe_activestate(@_);
> - } else {
> - return open_pipe_normal(@_);
> - }
> -}
> -
> -sub open_pipe_activestate {
> - tie *fh, "Git::ActiveStatePipe", @_;
> - return *fh;
> -}
> -
> -sub open_pipe_normal {
> - my (@execlist) = @_;
> -
> - my $pid = open my $kid, "-|";
> - defined $pid or die "Cannot fork: $!";
> -
> - unless ($pid) {
> - exec @execlist;
> - die "Cannot exec @execlist: $!";
> - }
> -
> - return $kid;
> -}I don't see that Git.pm provides the compatibility functionality we have stubbed out, here.
(It clearly has never been used, because there hasn't been a patch to set the actual ActiveState string there.. 'MSWin32', btw.)
I suspect that the other scripts, that have more users, will see regression complaints when the qx() calls get replaced by calls to open(my $fh, "-|"), indirectly, in Git.pm
-- Ryan Anderson sometimes Pug Majere