Re: [PATCH] git-commit: filter out log message lines only when editor was run.

From: Yann Dirson <ydirson@altern.org>
Date: Jun 24, 2006, 09:42 UTC
Message-ID: <20060624094217.GB7851@nowhere.earth>

Junio wrote:

> I agree with this in principle but we would need to make sure
> that our own scripts do not expect that the message is cleaned
> up when feeding a commit log message via stdin, -m or -F, and if
> they do fix them before applying this patch.

The only tools in git.git I could identify as using git-commit rather than commit-tree are:

git-revert.sh: OK git-rebase.sh: only uses -C

cogito, stgit, and pg also use commit-tree. Only qgit seems to be using git-commit, and probably makes use of this (mis)feature.

I guess the easiest way to get the 1.4.0 behaviour is to change git-commit calls to "git-commit -e" with EDITOR=true in the environment. I'm not sure it would be worth adding a new flag to switch on/off log stripping.

Best regards,

-- 
Yann Dirson    <ydirson@altern.org> |
Debian-related: <dirson@debian.org> |   Support Debian GNU/Linux:
                                    |  Freedom, Power, Stability, Gratis
     http://ydirson.free.fr/        | Check <http://www.debian.org/>