Re: [PATCH] Customizable error handlers
- From
Petr Baudis <pasky@suse.cz>
- Date
- Jun 23, 2006, 23:18 UTC
- Message-ID
- <20060623231807.GO21864@pasky.or.cz>
- In-Reply-To
- <7vsllv8ny8.fsf@assigned-by-dhcp.cox.net>
Dear diary, on Sat, Jun 24, 2006 at 01:14:07AM CEST, I got a letter where Junio C Hamano <junkio@cox.net> said that...
Show 24 quoted lines
> Petr Baudis <pasky@suse.cz> writes: > > > Dear diary, on Fri, Jun 23, 2006 at 03:32:27PM CEST, I got a letter > > where Petr Baudis <pasky@suse.cz> said that... > >> diff --git a/git-compat-util.h b/git-compat-util.h > >> index 5d543d2..e954002 100644 > >> --- a/git-compat-util.h > >> +++ b/git-compat-util.h > >> @@ -36,9 +36,13 @@ #endif > >> #endif > >> > >> /* General helper functions */ > >> -extern void usage(const char *err) NORETURN; > >> -extern void die(const char *err, ...) NORETURN __attribute__((format (printf, 1, 2))); > >> -extern int error(const char *err, ...) __attribute__((format (printf, 1, 2))); > >> +void usage(const char *err) NORETURN; > >> +void die(const char *err, ...) NORETURN __attribute__((format (printf, 1, 2))); > >> +int error(const char *err, ...) __attribute__((format (printf, 1, 2))); > > > > Wah, this kind of slipped through. Below is a patch without the > > externs removed. > > Oh, I first thought you did that on purpose as a cleanup. After > all don't they mean the same thing?
AFAIK they do, but we use extern everywhere and I personally consider it good style to externize declarations of, well, external functions.
-- Petr "Pasky" Baudis Stuff: http://pasky.or.cz/ A person is just about as big as the things that make them angry.