Re: What's in git.git and announcing v1.4.1-rc1

From: Petr Baudis <pasky@suse.cz>
Date: Jun 22, 2006, 20:58 UTC
Message-ID: <20060622205859.GF21864@pasky.or.cz>
In-Reply-To: <Pine.LNX.4.64.0606221301500.5498@g5.osdl.org>

Dear diary, on Thu, Jun 22, 2006 at 10:53:31PM CEST, I got a letter where Linus Torvalds <torvalds@osdl.org> said that...

> So in order to avoid a lot of blind git users, please apply this patch.

Great, since this also seems to make git diff more or less consistent with cg diff in the colors choice.

Show 12 quoted lines

>  enum color_diff {
> -	DIFF_PLAIN = 0,
> -	DIFF_METAINFO = 1,
> -	DIFF_FILE_OLD = 2,
> -	DIFF_FILE_NEW = 3,
> +	DIFF_RESET = 0,
> +	DIFF_PLAIN = 1,
> +	DIFF_METAINFO = 2,
> +	DIFF_FRAGINFO = 3,
> +	DIFF_FILE_OLD = 4,
> +	DIFF_FILE_NEW = 5,
>  };

Isn't manually numbering the enum choices somewhat pointless, though? (Actually makes it more difficult to do changes in it later.)

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
A person is just about as big as the things that make them angry.