Re: [PATCH] Make t8001-annotate and t8002-blame more portable

From: Dennis Stosberg <dennis@stosberg.net>
Date: Jun 18, 2006, 22:06 UTC
Message-ID: <20060618220654.G4a2f724@leonov.stosberg.net>
In-Reply-To: <7v3be218ri.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 12 quoted lines

> > +    'perl -pi -e "s/^1A.*\n$//; s/^3A/99/" file &&
> >      GIT_AUTHOR_NAME="D" git commit -a -m "edit"'
> 
> The first line in the original is removed while the perl version
> seems to just makes it empty -- ah, you remove the trailing LF
> as well there.  I've never seen this done like this, but OK.
> 
> It would have been more obvious if it were written like this:
> 
> 	$_ = "" if ($. == 1);
> 
> but probably it is just me.

I have no strong preference. Sometimes I find all those magic perl variables like $. $| $, $" and so on hard to distinguish without looking in the manual...

Regards, Dennis