Re: git-1.4.0 make problems
- From
- Michael Somos <somos@grail.cba.csuohio.edu>
- Date
- Jun 17, 2006, 14:46 UTC
- Message-ID
- <200606171446.k5HEkZAx006686@grail.cba.csuohio.edu>
Dennis Stosberg wrote :
> I have seen this test failing on FreeBSD 5.3, too. FreeBSD comes with a > version of "diff" which does not add the "\ No newline at end of file" > remark. Maybe your "diff" is simply too old. In that case, it's not a > serious problem because Git uses its own internal diff implementation.
You are exactly right. My "diff" is a bit too old. It was 2.7 and the latest stable is 2.8.1 which fixes the newline problem.
> The intention of this test is to test git-apply and not the system's > "diff", so perhaps it should bring along all its patches and not rely > on the system's "diff" to generate them...
That seems like a good suggestion if it is as you wrote. Thanks for the information regarding diff and git. Shalom, Michael