Re: [PATCH] CVSps fixed; git-cvsimport works, too

From: Chris Shoemaker <c.shoemaker@cox.net>
Date: Jun 17, 2006, 13:20 UTC
Message-ID: <20060617132023.GA29452@pe.Belkin>
In-Reply-To: <20060617122158.GQ7766@nowhere.earth>

On Sat, Jun 17, 2006 at 02:21:58PM +0200, Yann Dirson wrote:

Show 10 quoted lines

> [for original thread see
> http://www.gelato.unsw.edu.au/archives/git/0511/11812.html]
> 
> Hi Chris,
> 
> I was looking at your patch and test script to decide whether to
> include it in my cvsps patch collection, but it seems there are still
> problems:
> 
> * when run with "-x" it gives the expected result, even with "-A"

This is expected.

> 
> * when run without "-x" and without "-A", the patchset introducing
> file "b" and branch "stable" does not appear, without even a warning

With out "-A" I don't think the patch is operative.

> 
> * when run with "-A" cvsps notices the inconsistency:
> 
> invalid initial_branch for file a, probably from old cache, run with -x.

good advice.

Show 5 quoted lines

> 
> 
> I have included the current version of your patch in branch "to-check"
> in http://ydirson.free.fr/soft/git/cvsps.git/.  I did not tak time to
> look at it closely yet - do you plan to work on this issue ?

I wondered if you'd find that.  Evidentally, you're being thorough. :)

The intent of my patch is only to affect the branch ancestry calculation. IIRC, the patch version is incompatible with cached results from unpatched versions. Hence I would only expect it to work with '-x -A' (unless there was no pre-existing cache file).

I've had one independent report of success from someone who found and used my patch.

I haven't had to use cvsps recently, so I don't know how much time I'll have for cvsps hacking, but I'm interested in getting feedback on my current patch.

There's probably some nicer way to handle the cache incompatibility, but my current approach has been to tell people to delete their old cache file or run wih -x. Suggestions are welcome.

-chris