git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: HEAD branch duplicated in remotes/origin

From
Uwe Zeisberger <zeisberg@informatik.uni-freiburg.de>
Date
Jun 8, 2006, 12:33 UTC
Message-ID
<20060608123337.GA12456@informatik.uni-freiburg.de>
In-Reply-To
<7vverc9i4i.fsf@assigned-by-dhcp.cox.net>
Hello Junio,
Junio C Hamano wrote:
Show 43 quoted lines
> Uwe Zeisberger <zeisberg@informatik.uni-freiburg.de> writes:
> 
> > when cloning with --use-separate-remote, $GITDIR/remotes/origin contains
> > two references to refs/heads/master.
> 
> Thanks for noticing.
> 
> Very lightly tested but I think this should fix it.
> -- >8 --
> git-clone: fix duplicated "master" in $GIT_DIR/remotes/origin
> 
> Under --use-separate-remote we ended up duplicating the branch
> remote HEAD pointed at in $GIT_DIR/remotes/origin file.
> 
> Signed-off-by: Junio C Hamano <junkio@cox.net>
> ---
> diff --git a/git-clone.sh b/git-clone.sh
> index de59904..64318b4 100755
> --- a/git-clone.sh
> +++ b/git-clone.sh
> @@ -391,11 +391,16 @@ Pull: refs/heads/$head_points_at:$origin
>  		(cd "$GIT_DIR/$remote_top" && find . -type f -print) |
>  		while read dotslref
>  		do
> -			name=`expr "$dotslref" : './\(.*\)'` &&
> -			test "$use_separate_remote" = '' && {
> -				test "$head_points_at" = "$name" ||
> -				test "$origin" = "$name"
> -			} ||
> +			name=`expr "$dotslref" : './\(.*\)'`
> +			if test "z$head_points_at" = "z$name"
> +			then
> +				continue
> +			fi
> +			if test "$use_separate_remote" = '' &&
> +			   test "z$origin" = "z$name"
> +			then
> +				continue
> +			fi
>  			echo "Pull: refs/heads/${name}:$remote_top/${name}"
>  		done >>"$GIT_DIR/remotes/$origin" &&
>  		case "$use_separate_remote" in
> 

I wonder if this is easier not to add the other duplicate. That is let this as it is and don't add the head HEAD points at. Don't know, didn't look into it.

Moreover, is it sound to error if a Pull: line is duplicated? In my eyes at least the error message is wrong/missleading. Otherwise the patch works for me, but probably I only did the same testing as you.

Best regards Uwe

-- 
Uwe Zeisberger

cal 9 1752 | grep 10
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 4 in “HEAD branch duplicated in remotes/origin”
  1. Uwe ZeisbergerJun 8, 2006
  2. Junio C HamanoJun 8, 2006
  3. Uwe ZeisbergerJun 8, 2006
  4. Junio C HamanoJun 8, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.