Re: [PATCH] Support for configurable git command aliases (v2)

From: Petr Baudis <pasky@ucw.cz>
Date: Jun 4, 2006, 22:19 UTC
Message-ID: <20060604221930.GW10488@pasky.or.cz>
In-Reply-To: <mj+md-20060604.221036.15619.albireo@ucw.cz>

Hi,

Dear diary, on Mon, Jun 05, 2006 at 12:11:14AM CEST, I got a letter where Martin Mares <mj@ucw.cz> said that...

Show 6 quoted lines

> > And I forgot to mention that it also adds the interactivity test
> > requested by Janek - aliases are now interpreted only when stdout is a
> > tty.
> 
> Does this really make sense? Why should an alias stop working
> if I happen to redirect its output? Or am I missing something?

  make

	[alias]
	log = log --pretty=raw

and then any script that works on git log output might get very confused.

  Then again, as pointed out on IRC you might get very confused as well
if you do git log | less. Besides, this is not going to help you with
aliases like commit = commit -a.

  So, some other possibilities are to:

  (i) Test stdin. Even in scripts, stdin is frequently terminal, but you
might add </dev/null after each git invocation and get a serious case of
RSI.

  (ii) Add a --no-alias git argument. This way lies madness, too.

  (iii) Check a $GIT_NO_ALIAS environment variable. This might work
best, after all. Opinions? Or some other clever idea?

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
A person is just about as big as the things that make them angry.