Re: [PATCH 0/10] re-based and expanded tree-walker cleanup patches

From: Shawn Pearce <spearce@spearce.org>
Date: Jun 1, 2006, 03:11 UTC
Message-ID: <20060601031143.GA13392@spearce.org>
In-Reply-To: <7vpshtyffk.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

Show 10 quoted lines

> Linus Torvalds <torvalds@osdl.org> writes:
> 
> >  (a) git-rev-list --pretty=oneline "$upstream"..ORIG_HEAD > rev-list
> >
> >  (b) edit the rev-list, moving the single lines around, deleting them, etc
> >
> >  (c) cat rev-list |
> >      git-format-patch -k --stdout --stdin --full_index |
> >      git-am
> >

[snip]

Show 14 quoted lines

> What this means is:
> 
> 	git-format-patch $revargs
> 
> is not equivalent to
> 
> 	git-rev-list $revargs | git-format-patch --stdin
> 
> but is equivalent to
> 
> 	git-rev-list $revargs | tac | git-format-patch --stdin
> 
> 
> Thoughts from the list?

Aside from not knowing what tac is I agree with the latter. It is what the user would expect to happen. Except maybe add a --ancestors-first option to git-rev-list to do what tac does before outputting the revisions?

	git-rev-list --ancestors-first $revargs | git-format-patch --stdin

-- 
Shawn.