git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-send-email.perl extract_valid_address issue

From
EWEric Wong <normalperson@yhbt.net>
Date
May 29, 2006, 22:12 UTC
Message-ID
<20060529221240.GE24077@localdomain>
In-Reply-To
<200605292109.k4TL9g7E014263@laptop11.inf.utfsm.cl>
Horst von Brand <vonbrand@inf.utfsm.cl> wrote:
Show 28 quoted lines
> Fix regexps to better match email addresses if Email::Valid isn't present
> Make it return the address on match containing a @
> 
> Signed-off-by:  Horst H. von Brand <vonbrand@inf.utfsm.cl>
> ---
>  git-send-email.perl |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 312a4ea..6e39f2f 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -309,14 +309,14 @@ sub extract_valid_address {
>  	my $address = shift;
>  
>  	# check for a local address:
> -	return $address if ($address =~ /^([\w\-]+)$/);
> +	return $address if ($address =~ /^([\w\-.]+)$/);
>  
>  	if ($have_email_valid) {
>  		return Email::Valid->address($address);
>  	} else {
>  		# less robust/correct than the monster regexp in Email::Valid,
>  		# but still does a 99% job, and one less dependency
> -		return ($address =~ /([^\"<>\s]+@[^<>\s]+)/);
> +		return ($address =~ /([\w\-.]+@[\w\-.]+)/) ? $1 : undef;
>  	}
>  }
Oops on the original bug, my fault :x
Acked-by: Eric Wong <normalperson@yhbt.net>
-- 
Eric Wong
Previous: Horst von Brand
Message 19 of 19 in “Re: Git 1.0 Synopis (Draft v3”
  1. Horst von BrandJul 31, 2005
  2. Git 1.0 Synopis (Draft v4)Ryan Anderson, Aug 15, 2005
  3. Ryan AndersonAug 15, 2005
  4. Junio C HamanoAug 15, 2005
  5. Ryan AndersonAug 15, 2005
  6. Junio C HamanoAug 15, 2005
  7. Ryan AndersonAug 15, 2005
  8. Junio C HamanoAug 15, 2005
  9. Daniel BarkalowAug 15, 2005
  10. Junio C HamanoAug 16, 2005
  11. Johannes SchindelinAug 16, 2005
  12. Dongsheng SongAug 16, 2005
  13. about git server & permissionsDongsheng Song, Aug 16, 2005
  14. Johannes SchindelinAug 16, 2005
  15. Daniel BarkalowAug 16, 2005
  16. Daniel BarkalowAug 16, 2005
  17. Horst von BrandMay 29, 2006
  18. Horst von BrandMay 29, 2006
  19. Eric WongMay 29, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.