[PATCH] git-send-email.perl extract_valid_address issue
- From
- Nicolas Troncoso Carrere <ntroncos@alumnos.inf.utfsm.cl>
- Date
- May 29, 2006, 04:00 UTC
- Message-ID
- <200605290000.44463.ntroncos@alumnos.inf.utfsm.cl>
The third fallback was returning if the match was done or not instead of returning the actual email address that was matched. This prevented sending the mail to the people included in the CC. This bug only affect those that dont have Email::Valid.
I initialized $valid_email as undef so it would mimic the behavior of Email::Verify->address(), which returns undef if no valid address was found.
Signed-off-by: Nicolas <ntroncos@inf.utfsm.cl>
---
git-send-email.perl | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
84853ca89c15de7a24e9eb9fd422654b86c63be9
diff --git a/git-send-email.perl b/git-send-email.perl index 312a4ea..dfff3e6 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -316,7 +316,9 @@ sub extract_valid_address { } else { # less robust/correct than the monster regexp in Email::Valid, # but still does a 99% job, and one less dependency - return ($address =~ /([^\"<>\s]+@[^<>\s]+)/); + my $valid_email=undef; + ($valid_email ) = ($address =~ /([^\"<>\s]+@[^<>\s]+)/); + return ($valid_email); } }
-- Nicolás Troncoso Carrère User #272312 counter.li.org Estudiante Magíster en Ciencias de la Informática Universidad Técnica Federico Santa María http://www.alumnos.inf.utfsm.cl/~ntroncos